Rule Change: Suggestion fixer for prefer-destructuring

[Samuel-Therrien-Beslogic]

What rule do you want to change?

prefer-destructuring

What change do you want to make?

Implement suggestions

How do you think the change should be implemented?

A new default behavior

Example code

const selectedCost = costs[index_ - 1]

What does the rule currently do for this code?

Warn but doesn't offer fixes

What will the rule do after it's changed?

Offer a suggestion to manually fix:

const {[index_ - 1]: selectedCost} = costs

Participation

• I am willing to submit a pull request to implement this change.

Additional comments

My original use-case was actually for @typescript-eslint/prefer-destructuring. If I understand correctly, if this is added for ESLint, typescript-eslint should follow with their support.

From:

export abstract class Question {
  readonly id?: number
  readonly text: string

  constructor(data: {
    readonly id?: number,
    readonly text: string,
  }) {
    this.id = data.id
    this.text = data.text
  }
}

To:

export abstract class Question {
  readonly id?: number
  readonly text: string

  constructor(data: {
    readonly id?: number,
    readonly text: string,
  }) {
    ({ id: this.id, text: this.text } = data)
  }
}

The parenthesis requirement make the enforceForRenamedProperties option hard for me to enable as I feel like other team members will also get confused as to why the syntax is incorrect until realizing that parenthesis are required w/o assignement keywords.

[aladdin-add]

the plugin is not maintained by eslint team. please file it in https://github.com/typescript-eslint/typescript-eslint.

[Samuel-Therrien-Beslogic]

@aladdin-add I did mean prefer-destructuring and accidentally left in @typescript-eslint. I've updated the post accordingly. Could you please reopen?

[Tanujkanti4441]

Hi @Samuel-Therrien-Beslogic,

const selectedCost = costs[index_ - 1]
fixes to
const {[index_ - 1]: selectedCost} = costs

this example is a bit confusing, while const selectedCost = costs[index_ - 1]; accesses an array element directly, the fix const {[index_ - 1]: selectedCost} = costs; suggests object destructuring, which is not applicable to arrays
can you please add some code example you want to have suggestions for with appropriate fixes?